[#TFS11] Team Explorer (V): A better Code Review process

Hi,

the post of Rodrigo Corral “in the software, the quality is not optional” is a post to which I refer every few minutes as point of entry to explain why it is important to think about software “well done” from zero-day. Each time that we make a copy/paste of a portion of code or implement a “quick fix” we are creating a future problem, that as time goes on, will be much harder to solve ás. Refactor code is important, I once I see old code, always think in better ways to implement it. And another great tool that we have at our disposal is the ability to perform Code Review on our code. Code Review processes are described explicitly in some development teams, but usually it is a practice that does not implement formalemente.However once you together with a partner, to give a hand to solve a problem or to find out how you can take forward a requirement, because you are doing a Code Review activity.

Visual Studio 11 and Team Foundation 11 include specific functionality for this scenario, where in addition to having the ability to work distributed have traceability of actions that we are doing. For example, suppose that with my user “El Bruno” I finished implementing a certain functionality and want another developer to help me validate if it is correct. In the new Team Explorer, we can see in the section “My Work“, the “Request Review” action.

When we ask for a Review, we will have to define what developer will be carried out, and we can also complete with a comment, the area of work, etc.

Once requested, in the section “My Work” already we can see that we have a pending Request for Julia Ilyiana in a Code Review.

When Julia accessing Visual Studio 11 and see their work for today’s “My Work”, this Panel will see the request for Code Review asked Bruno. It is also possible to filter to see the CR requested and received.

When Julia opens the request of Bruno, you can see the data of the request. An important detail is that a Code Review can be assigned to one or more reviewers. For example, Julia could send your comments in regard to another developer with more knowledge on the subject. We see in the pictures below you have added to Brian Keller as an additional reviewer.

Once “revised” code, julia can comment on it and share these views with the participants of the Code Review.

This comment may be a general comment about code files, or even a specific piece of code in a class.

Internally a Code Review is a WorkItem, so we can see the history to see how evolved the same.

Finally when Bruno see the status of the reviews, can be seen as helped the other participants therein, and

Bruno can now comment on or share information from the Review in the same again. In addition to view more specific data shared in the review.

Finally, when closes a Code Review, we can see the data as if it were one WorkItem. However, as the information that shows the Code Review is not very practical in the displayed of WorkItems, can access the view in Team Explorer from the own Viewer. Cool Open-mouthed smile